LG-3896, LG-3898: Date Picker input selection #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38f15d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +123 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
shaneeza
changed the title
packages/date-picker/src/DatePicker/DatePickerInput/DatePickerInput.tsx
Outdated
Show resolved
Hide resolved
TheSonOfThomp
requested changes
Feb 2, 2024
packages/date-picker/src/DatePicker/DatePickerInput/DatePickerInput.tsx
Outdated
Show resolved
Hide resolved
packages/date-picker/src/shared/components/DateInput/DateInputBox/DateInputBox.spec.tsx
Outdated
Show resolved
Hide resolved
packages/date-picker/src/shared/components/DateInput/DateInputSegment/DateInputSegment.spec.tsx
Outdated
Show resolved
Hide resolved
packages/date-picker/src/shared/components/DateInput/DateInputSegment/DateInputSegment.tsx
Outdated
Show resolved
Hide resolved
packages/date-picker/src/shared/components/DateInput/DateInputSegment/DateInputSegment.tsx
Outdated
Show resolved
Hide resolved
| @@ -111,7 +111,7 @@ export const DatePickerInput = forwardRef<HTMLDivElement, DatePickerInputProps>( | |||
|
|
|||
| switch (key) { | |||
| case keyMap.ArrowLeft: { | |||
| // Prevent the cursor on tab and initial click | |||
| // Without this, the input does not select all the text | |||
There was a problem hiding this comment.
I'm still a bit unclear on how preventing default keydown behavior prevents selection
There was a problem hiding this comment.
I'm unsure how to explain this -- without preventDefault, the input ignores .select(), and I'm unsure why.
There was a problem hiding this comment.
Hmm, If you have time, this would be an interesting thing to investigate why
shaneeza
commented
Feb 16, 2024
packages/date-picker/src/shared/components/DateInput/DateInputSegment/DateInputSegment.spec.tsx
Outdated
Show resolved
Hide resolved
packages/date-picker/src/shared/components/DateInput/DateInputSegment/DateInputSegment.tsx
Outdated
Show resolved
Hide resolved
TheSonOfThomp
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Note: Changes are explained in detail in the changeset
🎟 Jira ticket: LG-3896
🎟 Jira ticket: LG-3898
The issue in 3898 is that when using the left and right arrows, the caret moves to the middle of the value instead of the first and last index and typing doesn't update the value. This could be fixed by LG-3896, which suggests removing the caret so we won't have caret issues.
Removing the caret is tricky, but I think I found a good workaround. The caret will still exist and could end up in the middle of an input on click, but once you start typing, the input value will reset. Furthermore, I made some tweaks so that if you tab into an input or initially click on an input, the entire input will become selected, resetting the value once you start typing.
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes